fix: AI Services provisioning order for private endpoint CognitiveServices/accounts fail#1052
Closed
Ashwal-Microsoft wants to merge 1 commit into
Closed
fix: AI Services provisioning order for private endpoint CognitiveServices/accounts fail#1052Ashwal-Microsoft wants to merge 1 commit into
Ashwal-Microsoft wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how AI service deployments and role assignments are handled in the
infra/main.bicepfile. The main change is moving the deployment and role assignment configurations from the main AI service module into a dedicated submodule, which improves modularity and maintainability.Refactoring of AI service deployment and role assignments:
deploymentsandroleAssignmentsproperties from the mainaiFoundryAiServicesmodule definition, simplifying its configuration.aiFoundryAiServicesDeployments(usingmodules/ai-services-deployments.bicep), to handle AI model deployments and role assignments separately. This submodule is only deployed if a new AI Foundry AI Project is being created.Dependency management:
dependsOnlogic to ensure the correct deployment order when private networking is enabled, and to make the new deployments module depend on the main AI service resource.## PurposeDoes this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information